Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #2 from 20squares/PR-documentation #6

Merged
merged 3 commits into from
May 15, 2023
Merged

Merge pull request #2 from 20squares/PR-documentation #6

merged 3 commits into from
May 15, 2023

Conversation

FabrizioRomanoGenovese
Copy link
Member

Hey Andreas, this is what we have up to now. Give it a look!

@FabrizioRomanoGenovese
Copy link
Member Author

...By the way, we added nix flake functionality, which should make installation simpler!

andreas-blockswap
andreas-blockswap approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@andreas-blockswap andreas-blockswap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation

blockswap-PoN/README.md

### Reporter has no slashing

This has been one of the most contentious points so far. As PoN is defined, **Reporter** must supply no collateral to PoN, not in the form of staked capital, nor in the form of fees. This means that **Reporter** cannot be penalized by PoN for reporting untruthfully. So, we assumed no negative payoffs for **Reporter** in case of invalid reporting.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. Since the reports are verified we may assume that a reporter cannot submit an invalid report.

@FabrizioRomanoGenovese
Copy link
Member Author

FabrizioRomanoGenovese commented May 15, 2023 •
edited
Loading

@andreas-blockswap, documentation apart, did the code look and run as expected? If it did and there are no issues, I will close the PR. I just wanted to double check because if there are problems they are obviously easier to solve now than later.

@andreas-blockswap
Copy link
Collaborator

@andreas-blockswap, documentation apart, did the code look and run as expected? If it did and there are no issues, I will close the PR. I just wanted to double check because if there are problems they are obviously easier to solve now than later.

Seems to work with stack run. Tries a few different strategies and for each strategy it reports something like

 Strategies are in equilibrium
 NEWGAME: 

 Strategies are in equilibrium
 NEWGAME: 

...

@FabrizioRomanoGenovese
Copy link
Member Author

Oke then, I'll merge! If you have any other observations about the strategies implemented (or you want to try different strategies) let us know!

@FabrizioRomanoGenovese FabrizioRomanoGenovese merged commit d2615cd into main May 15, 2023
@FabrizioRomanoGenovese FabrizioRomanoGenovese deleted the philipp branch May 15, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-blockswap andreas-blockswap andreas-blockswap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabrizioRomanoGenovese @andreas-blockswap