Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Volunteers section with Grids #100

Closed
wants to merge 17 commits into from

Conversation

davyj123
Copy link

@davyj123 davyj123 commented Dec 29, 2021

GitHub license Open Source Love PRs Welcome

  1. Kind of change this PR introduce :
    This pr contain changes related to the Redesign the volunteer section #4 Redesign the volunteer section.
    In this pr the volunteer section is redesigned.
  2. Issue it resolves :
    Prevoius UI contain tabular representation of volunteer section which is not so good according to modern Ui's.
    In this pr volunteer section is redesigned to modern flex based design with good looking tiles.
  3. Screenshots & GitHub Page Link :
    Screenshot (158)

Changed To :-

Screenshot (179)

Issue it resolves :- #4
Github Page Link :- https://davyj123.github.io/Blood-Buddy/

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you've changed anything cuz I am seeing this, @davyj123

image

@davyj123
Copy link
Author

Done.

@davyj123
Copy link
Author

that's my little mistake

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eview.mp4

@davyj123

@davyj123
Copy link
Author

ok mam

@davyj123
Copy link
Author

mam actually working proper at my local repo

@davyj123
Copy link
Author

Updated succesfully

@davyj123
Copy link
Author

Not showing any scroll bar
Screenshot (180)

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix these @davyj123 :

  1. image

  2. Where's the spacing in b/w 'em:
    image

  3. Fix the footer:
    image

@davyj123
Copy link
Author

Done

@davyj123
Copy link
Author

@2024-SANDHYA done with all changes

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davyj123 This is original one :

image

This is where you messed up a bit :

image

Don't play with the hero section please.

@davyj123
Copy link
Author

Mam it is already perfect
Screenshot (182)

@davyj123
Copy link
Author

All things are done from myside now.

@davyj123
Copy link
Author

I have decreased font size by 6px because it is making website irresponsive in mobile widths.

@davyj123
Copy link
Author

davyj123 commented Jan 5, 2022

Mam when will this pr will get merged

@2024-SANDHYA
Copy link
Owner

@davyj123 Pull the latest changes from the repo. Seek help from mentors @davyj123

@davyj123
Copy link
Author

davyj123 commented Jan 7, 2022

I pulled the latest changes. Now what i have to do.

@davyj123
Copy link
Author

davyj123 commented Jan 8, 2022

Mam please guide me

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button is not like this, check the existing site and correct it accordingly @davyj123

image

Add the spacing between this

image

@2024-SANDHYA
Copy link
Owner

Also @davyj123 Pull and merge the latest changes from the repo, I can see you have not done anything

@davyj123
Copy link
Author

davyj123 commented Jan 9, 2022

Done with previous design of register button
Screenshot (199)

@davyj123
Copy link
Author

Please Check it.

@2024-SANDHYA
Copy link
Owner

Fix these @davyj123 :

1. ![image](https://user-images.githubusercontent.com/75671152/147679698-340cfa07-5e8d-44eb-81bc-e5f0ccbbc242.png)

2. Where's the spacing in b/w 'em:
   ![image](https://user-images.githubusercontent.com/75671152/147679773-425b2c01-85ce-461a-9ca8-996600310b21.png)

3. Fix the footer:
   ![image](https://user-images.githubusercontent.com/75671152/147679895-6b1791f7-35fb-481c-8523-82828fe8ab8e.png)

@davyj123 You have not worked on the second issue.

@davyj123
Copy link
Author

Done second one.

@davyj123
Copy link
Author

Mam You have assigned me #114. Please tell me if i will make a github page link for that then this will expires or this will remain in working condition?

@2024-SANDHYA
Copy link
Owner

Mam You have assigned me #114. Please tell me if i will make a github page link for that then this will expires or this will remain in working condition?

Both will work ofc. @davyj123

@2024-SANDHYA
Copy link
Owner

Pull the latest changes from the repo first @davyj123

@davyj123
Copy link
Author

Alredy pulled

@davyj123
Copy link
Author

Now please tell me this will get merged or any issues yet.

@2024-SANDHYA
Copy link
Owner

Pull that again please, follow what I am saying @davyj123 Because recent changes are added to the code.

@davyj123
Copy link
Author

I pulled again using fetch stream then pulled to update my local repo and then repushed my changes to my branch.

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts @davyj123

@davyj123
Copy link
Author

Now please help me in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants