Use php-based configs when xml is not available anymore

[Chris53897]

(since Symfony 8)

[Chris53897]

@bytehead

I did update composer.json locally to test it with adding symfony 8 and i added

"minimum-stability": "beta",
"prefer-stable": false

Tests are green.

[bytehead]

Looks good, just some CS nitpick ☺️

[bytehead]

Thank you @Chris53897!

[skmedix]

Quick question: what’s the point of keeping both XML and PHP configs? If both are supported, and there’s no BC issue with PHP config, and they’re functionally identical, why not just leave PHP config?

[Chris53897]

The reason is that symfony 8 does not support xml-based configs anymore.
To support Symfony 5.4 to 8.x it is necessary to support xml and php based.
Once support for symfony 5.4 is dropped, the xml-based configs can be dropped.

[skmedix]

The reason is that symfony 8 does not support xml-based configs anymore. To support Symfony 5.4 to 8.x it is necessary to support xml and php based. Once support for symfony 5.4 is dropped, the xml-based configs can be dropped.

However, this does not answer my question. Symfony 5.4-8.0 supports PhpFileLoader, so in my opinion, there is no reason or benefit of keeping the XML config. By migrating to PHP config completely, we do not introduce a BC.

[Chris53897]

@skmedix You are right. I was not aware that PhpFileLoader is available in Symfony 5.4. (Misleaded by an other PR)

I do not know how to rewrite this test, to use the PHP File instead of the .xml file.
https://github.com/1up-lab/OneupFlysystemBundle/blob/main/tests/DependencyInjection/OneupFlysystemExtensionTest.php#L95

[skmedix]

I do not know how to rewrite this test, to use the PHP File instead of the .xml file. main/tests/DependencyInjection/OneupFlysystemExtensionTest.php#L95

Try this:

public function testAdapterAvailability(): void
{
    $container = new ContainerBuilder();
    $loader = new PhpFileLoader($container, new FileLocator(__DIR__ . '/../../src/Resources/config'));
    $loader->load('adapters.php');

    foreach ($container->getDefinitions() as $id => $definition) {
        if ('service_container' === $id) {
            continue;
        }

        $class = $definition->getClass();
        if (null !== $class) {
            self::assertTrue(class_exists($class), 'Could not load class: ' . $class);
        }
    }
}

@Chris53897