Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] dataconv: SharedDict for concurrent access #49

Merged
merged 27 commits into from
Feb 23, 2024
Merged

[feat] dataconv: SharedDict for concurrent access #49

merged 27 commits into from
Feb 23, 2024

Conversation

hyorigo
Copy link
Collaborator

@hyorigo hyorigo commented Feb 22, 2024

No description provided.

Copy link

codacy-production bot commented Feb 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.59% (target: -1.00%) 93.59%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (95cff61) 2391 2088 87.33%
Head commit (0246219) 2541 (+150) 2234 (+146) 87.92% (+0.59%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#49) 156 146 93.59%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 91.44737% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 84.40%. Comparing base (95cff61) to head (0246219).

Files Patch % Lines
dataconv/share.go 95.17% 5 Missing and 2 partials ⚠️
internal/testloader.go 14.28% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   83.72%   84.40%   +0.67%     
==========================================
  Files          22       23       +1     
  Lines        2322     2468     +146     
==========================================
+ Hits         1944     2083     +139     
- Misses        296      300       +4     
- Partials       82       85       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyorigo hyorigo merged commit d55408d into master Feb 23, 2024
18 checks passed
@hyorigo hyorigo deleted the sahre branch February 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant