Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use user defined logger for starlet log module #9

Merged
merged 3 commits into from
Jun 25, 2024
Merged

use user defined logger for starlet log module #9

merged 3 commits into from
Jun 25, 2024

Conversation

hyorigo
Copy link
Contributor

@hyorigo hyorigo commented Jun 25, 2024

  • allow user custom log
  • for lock

@hyorigo hyorigo changed the title use custom logger for standard module use user defined logger for starlet log module Jun 25, 2024
Copy link

codacy-production bot commented Jun 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (521371d) 723 716 99.03%
Head commit (caee594) 755 (+32) 748 (+32) 99.07% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#9) 30 30 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.64%. Comparing base (521371d) to head (caee594).

Files Patch % Lines
module.go 90.90% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   98.59%   98.64%   +0.04%     
==========================================
  Files           6        6              
  Lines         710      736      +26     
==========================================
+ Hits          700      726      +26     
  Misses          7        7              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyorigo hyorigo merged commit 8abe339 into master Jun 25, 2024
24 of 25 checks passed
@hyorigo hyorigo deleted the slog branch June 25, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant