use /status to get time drift before sending any intents #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkieltyka
requested changes
Nov 6, 2024
packages/waas/src/auth.ts
Outdated
| const res = await fetch(`${this.config.rpcServer}/status`) | ||
| const date = res.headers.get('Date') | ||
| if (!date) { | ||
| throw new Error('missing Date header value') |
There was a problem hiding this comment.
change error to, failed to get Date header value from /status ... and probably better is to have a well-defined error in the waas ridl for any error type.. but the above message will do for now
pkieltyka
reviewed
Nov 6, 2024
packages/waas/src/intents/base.ts
Outdated
| @@ -11,9 +11,22 @@ export type SignedIntent<T> = Omit<RawIntent, 'data'> & { data: T } | |||
| const INTENTS_VERSION = 1 | |||
| const VERSION = `${INTENTS_VERSION} (Web ${PACKAGE_VERSION})` | |||
|
|
|||
| export function getTimeDrift() { | |||
| const drift = sessionStorage.getItem('timeDrift') | |||
There was a problem hiding this comment.
your code will throw in react native and node
pkieltyka
reviewed
Nov 6, 2024
packages/waas/src/intents/base.ts
Outdated
|
|
||
| export function getTimeDrift() { | ||
| if (isSessionStorageAvailable()) { | ||
| const drift = sessionStorage.getItem(timeDriftKey) |
There was a problem hiding this comment.
should we use window.sessionStorage.getItem(..) to be explicit..? the "window" part that is..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.