Ethers v6 #483
Draft
Ethers v6 #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkieltyka
reviewed
Feb 25, 2024
| @@ -42,15 +42,15 @@ const main = async () => { | |||
| { | |||
| name: 'hardhat', | |||
| chainId: 31337, | |||
| rpcUrl: provider.connection.url, | |||
| rpcUrl: provider._getConnection().url, | |||
There was a problem hiding this comment.
this is kinda weird.. we shouldn't need to use _ methods.. is there nothing else with this info on the object..?
packages/account/src/account.ts
Outdated
| @@ -82,11 +82,11 @@ class Chain0Reader implements commons.reader.Reader { | |||
| return undefined | |||
| } | |||
|
|
|||
| async nonce(_wallet: string, _space: ethers.BigNumberish): Promise<ethers.BigNumberish> { | |||
| return ethers.constants.Zero | |||
| async nonce(_wallet: string, _space: BigIntish): Promise<bigint> { | |||
There was a problem hiding this comment.
ethers still has the ethers.BigNumberish type, but now it uses native bigInt or strings ..
Our response type is now Promise<bigint> ... what is bigint ..? Im just wondering what is most sensible return type..
… to wrap the WalletRequestHandler response data as JsonRpcResponse
…een older versions of sequence.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.