Update Falcon verification to use horner_eval_base
#1661
Conversation
| #[test] | ||
| fn test_falcon512_probabilistic_product_failure() { | ||
| // Create a polynomial pi that is not equal to h * s2. | ||
| // create a polynomial pi that is not equal to h * s2. |
There was a problem hiding this comment.
The random_coefficients use rng - can we either fix a seed, or generate those coefficients deterministically?
| adv_push.2 | ||
| dup.1 dup.1 ext2inv | ||
| push.0.0 | ||
| loc_storew.4 |
There was a problem hiding this comment.
nit: can we add the state of the stack after this block?
| @@ -218,182 +207,83 @@ export.load_h_s2_and_product.4 | |||
| push.M u32lt assert | |||
| push.M u32lt assert | |||
|
|
|||
| horner_eval_base | |||
There was a problem hiding this comment.
can we also add some comments for the state of the stack in this loop? It's quite hard to follow
There was a problem hiding this comment.
I ran the miden-base tests on top of this branch, and I'm getting some NotU32 errors (for example, with the scripts::p2id::prove_consume_multiple_notes test).
Would be good to make sure the bus works fine too after we fix those (and #1664 might be useful if there's a bug there)
There was a problem hiding this comment.
My bad, miden-base reimplements the dsa::falcon_sign method which was updated in this PR. After updating it, all tests pass.
I also confirmed that the bus is fixed with this PR, which confirms the findings of #1664 that rcombbase was the problem.
As the title says. The current cycle count is around
57500cycles.