-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update styles to WinUI 2 #808
base: master
Are you sure you want to change the base?
Conversation
@Jasonstein there is a bug I noticed in WinUI2 which have been reported here we can either wait for it to be fixed or update our styles for different behavior. Most of the work is done, I just have following queries to finish the transition:
|
|
@Jasonstein here are comparison some of the design changes:
|
Overall looks good to me. There is only one thing that makes me sad: most of the current Windows apps are still using rectangle design and also the app Window itself is a rectangle and it does not fit well with the overall rounded corners of the controls. Maybe we should do it later once Windows is fully embracing the rounded corner design and I believe it should be coming real soon. Is there any way to keep all your existing work as it is but set the corner radius to 0 and makes it look just like before? And when time is right, we can set it to rounded corner if that's doable. |
I have disabled rounded corners for now and added notes to reenable them once SunValley becomes GA. Also, are you satisfied with the WinUI's Colorpicker or do you want to use the Community Toolkit's Colorpicker?? Regarding the WinUI's |
This PR fixes conflicts in #806. With WCT moving to WinUI 2.5 it is essential Notepads should update to WinUI 2.5 to maintain compatibility. Most of the designs have been updated to implement rounded corners etc.
PR Type
What kind of change does this PR introduce?