Add support for loading raw VMWare snapshots #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2024 18:14
A debugger won't work for vmware dumps, so just warn in that case and continue on. Additionally, there's some sort of discrepancy with cpu state between dumps from hyper-v and from vmware. Ignoring these didn't result in anything horrible, so warn on it but continue.
|
Woot that's awesome! As I have mentioned in private messages, give me some time to try to figure out what's the best way to do this that is shippable 🫡 Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches simply add support for loading VMWare snapshots which are raw, linear, RAM dumps.
The change in the kdump parsers is simple, if the initial parsing fails, it opportunistically tries to load the file as a raw dump, else it continues into parsing different usual kdumps types.
The second part of the patch has to do with actually loading these where I had to relax a few warnings or errors, as there's no point in trying to enable a debugger on raw memory dumps.
To build the project with support for loading these VMWare dumps, there's a new
build-release-vmware-support.batscript that enables the flags that relax the warnings.I'll have a macOS/fuzzer target and an example workflow in a separate repository.