Skip to content

Fix: card reopen issue #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanjaykumaryada
Copy link
Contributor

Description

#30 on the board page on clicking card , the page of the card appears (it's a popup). On closing popup, when want to reopen popup it was not getting closed, had to refresh. To resolve, made some changes when popup closes .

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style and structure of this project
  • My code follows the principles of clean code
  • My changes generate no new warnings, bugs or errors

Tags

hactoberfest, bug-fixes

@0l1v3rr
Copy link
Owner

0l1v3rr commented Oct 22, 2023

Hello @sanjaykumaryada,

This solution clearly solves the issue, but I believe introduces a new bug. For example, If I open a card and edit it, when I close the popup, the changes don't show up on the board until the page is refreshed. That's why the router.refresh() was there, but it caused the #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants