Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows sync #581

Merged
merged 4 commits into from
Jan 21, 2024
Merged

Fix windows sync #581

merged 4 commits into from
Jan 21, 2024

Conversation

Roshan-Mehta
Copy link
Contributor

A brief description of the changes in this PR:
sync command was failing in windows because of present of "" in path. This Pr fix the issue.

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@Roshan-Mehta Roshan-Mehta changed the base branch from staging to sprint-1.12 January 19, 2024 15:17
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 7d12e59 into sprint-1.12 Jan 21, 2024
3 of 4 checks passed
@dabasov dabasov deleted the fix-windows-sync branch January 21, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants