Add read command #405
Open
Add read command #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
peterlimg
requested changes
May 20, 2023
| remotePath := cmd.Flag("remotepath").Value.String() | ||
| authTicket := cmd.Flag("authticket").Value.String() | ||
| lookupHash := cmd.Flag("lookuphash").Value.String() | ||
| verifyDownload, err := cmd.Flags().GetBool("verifydownload") |
There was a problem hiding this comment.
Let's use verify to keep it short
| readerCmd.PersistentFlags().String("lookuphash", "", "The remote lookuphash of the object retrieved from the list") | ||
| readerCmd.Flags().BoolP("thumbnail", "t", false, "pass this option to download only the thumbnail") | ||
|
|
||
| readerCmd.Flags().IntP("blockspermarker", "b", 10, "pass this option to download multiple blocks per marker") |
There was a problem hiding this comment.
Let's use blocknum to keep it short, and remove the pass this option from the usage field. So could be Number of blocks to download per marker. Btw, is there any limit to the number.
|
@lpoli what's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the changes in this PR:
This PR adds read command that uses io.ReadSeekCloser interface to download file from an allocation.
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):