Skip to content

Transcoder#1782

Draft
storybehind wants to merge 14 commits into
stagingfrom
transcoder
Draft

Transcoder#1782
storybehind wants to merge 14 commits into
stagingfrom
transcoder

Conversation

@storybehind
Copy link
Copy Markdown
Collaborator

@storybehind storybehind commented Jul 28, 2025

Changes

  • Upload, createdir and deletedir through provided wallet.
  • miner reset list if single miner exceeds timeout. timeout is changed to 12s.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@storybehind storybehind requested a review from Hitenjain14 August 3, 2025 06:22
Comment thread core/client/set.go
client.wallets[w.ClientID] = &w
}

func GetWalletByClientID(clientID string) *zcncrypto.Wallet {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add the Go doc standard comments for the function GetWalletByClientID

Comment thread core/client/set.go
return client.wallets[clientID]
}

func AddWallet(wallet zcncrypto.Wallet) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add the Go doc standard comments for the function AddWallet

Comment thread zboxcore/zboxutil/http.go Outdated
return req, nil
}

func NewConnectionRequestByWallet(baseUrl, allocationID, allocationTx, sig string, body io.Reader, wallet *zcncrypto.Wallet) (*http.Request, error) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add the Go doc standard comments for the function NewConnectionRequestByWallet

Comment thread zboxcore/sdk/sdk.go
}
}

func DoMultiUploadByWallet(wallet zcncrypto.Wallet, a *Allocation, workdir string, localPaths []string, fileNames []string, thumbnailPaths []string, encrypts []bool, chunkNumbers []int, remotePaths []string, isUpdate []bool, isWebstreaming []bool, status StatusCallback) error {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add Go doc standard comments for the DoMultiUploadByWallet function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants