Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sign auth #1739

Merged
merged 2 commits into from
Jan 26, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion core/client/set.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"encoding/json"
"errors"
"fmt"
"github.com/0chain/gosdk/zcncore"
"strings"

"github.com/0chain/gosdk/core/conf"
Expand Down Expand Up @@ -55,7 +56,7 @@ type InitSdkOptions struct {

func init() {
sys.Sign = signHash
sys.SignWithAuth = signHash
sys.SignWithAuth = signHashWithAuth

sigC <- struct{}{}

Expand Down Expand Up @@ -95,6 +96,42 @@ var SignFn = func(hash string) (string, error) {
return ss.Sign(hash)
}

func signHashWithAuth(hash, signatureScheme string, keys []sys.KeyPair) (string, error) {
sig, err := sys.Sign(hash, signatureScheme, keys)
if err != nil {
return "", fmt.Errorf("failed to sign with split key: %v", err)
}

data, err := json.Marshal(zcncore.AuthMessage{
Hash: hash,
Signature: sig,
ClientID: client.wallet.ClientID,
})
if err != nil {
return "", err
}

if sys.AuthCommon == nil {
return "", errors.New("authCommon is not set")
}

rsp, err := sys.AuthCommon(string(data))
if err != nil {
return "", err
}

var sigpk struct {
Sig string `json:"sig"`
}

err = json.Unmarshal([]byte(rsp), &sigpk)
if err != nil {
return "", err
}

return sigpk.Sig, nil
}

func signHash(hash string, signatureScheme string, keys []sys.KeyPair) (string, error) {
retSignature := ""
for _, kv := range keys {
Expand Down
Loading