Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing in SHA of commit to associate check #29

Open
flcdrg opened this issue Jul 23, 2021 · 0 comments · May be fixed by #30
Open

Support passing in SHA of commit to associate check #29

flcdrg opened this issue Jul 23, 2021 · 0 comments · May be fixed by #30

Comments

@flcdrg
Copy link
Contributor

flcdrg commented Jul 23, 2021 •
edited
Loading

If you're separating out workflows like in https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#handling-push-events then you might want to run this action from a workflow triggered by the workflow_run event.

In that case the current logic doesn't pick up the correct commit SHA. In this situation it would be great to have a property that can be set to the SHA..

eg.

        with:
          report_name: Unit Tests
          report_title: Unit Tests
          github_token: ${{ secrets.GITHUB_TOKEN }}
          test_results_path: ./TestResults.trx
          sha: ${{ github.event.workflow_run.head_sha }}
flcdrg added a commit to flcdrg/dotnet-tests-report that referenced this issue Jul 23, 2021
@flcdrg
Add property for setting SHA
b982b1c 
- Allows overriding the 'auto-detection' logic

Fixes zyborg#29
flcdrg added a commit to flcdrg/dotnet-tests-report that referenced this issue Jul 23, 2021
@flcdrg
Add property for setting SHA
64c5b23 
- Allows overriding the 'auto-detection' logic

Fixes zyborg#29
flcdrg added a commit to flcdrg/dotnet-tests-report that referenced this issue Jul 23, 2021
@flcdrg
Add property for setting SHA
3b7e6a1 
- Allows overriding the 'auto-detection' logic

Fixes zyborg#29
@flcdrg flcdrg changed the title Support running from workflow_run event Support passing in SHA of commit to associate check Jul 23, 2021
@flcdrg flcdrg linked a pull request Jul 23, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add property for setting SHA flcdrg/dotnet-tests-report
1 participant
@flcdrg