Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "(no topic)" to "general chat" #23291

Open
Tracked by #23297
alya opened this issue Oct 19, 2022 · 10 comments
Open
Tracked by #23297

Rename "(no topic)" to "general chat" #23291

alya opened this issue Oct 19, 2022 · 10 comments
Assignees
Labels

Comments

@alya
Copy link
Contributor

alya commented Oct 19, 2022

At present, messages sent without a topic are displayed as going to "(no topic)". As discussed on CZO, we should make sending messages without a topic feel more normal/expected by renaming "(no topic)" to "general chat".

We want to have the server start allowing channel messages to have an empty topic at the API level, replacing the old "(no topic)" behavior. This should be displayed as something like "general chat" — with italics — in the UI.

The exact phrase to use for "general chat" is specified by the server in the API. For compatibility with old clients, the feature is gated by a flag the client sends. For details, see references below.

##References

Notes

Help center

/help/configure-who-can-edit-topics.md and /help/require-topics.md will need to be updated accordingly.

@zulipbot
Copy link
Member

zulipbot commented Oct 19, 2022

Hello @zulip/server-misc, @zulip/server-onboarding members, this issue was labeled with the "area: onboarding", "area: topics" labels, so you may want to check it out!

@sofbe
Copy link
Collaborator

sofbe commented Oct 20, 2022

@zulipbot claim

sofbe added a commit to sofbe/zulip that referenced this issue Oct 20, 2022
Messages sent without a topic is now displayed as going
to "general chat".

Fixes zulip#23291.
sofbe added a commit to sofbe/zulip that referenced this issue Oct 20, 2022
Messages sent without a topic is now displayed as going
to "general chat".

Update tests to work with the renaming.

Fixes zulip#23291.
sofbe added a commit to sofbe/zulip that referenced this issue Oct 20, 2022
Messages sent without a topic is now displayed as going
to "general chat".

Update tests to work with the renaming.

Fixes zulip#23291.
@timabbott timabbott mentioned this issue Oct 21, 2022
sofbe added a commit to sofbe/zulip that referenced this issue Oct 22, 2022
Messages sent without a topic is now displayed as going
to "general chat".

Update tests to work with the renaming.

Fixes zulip#23291.
@zulipbot
Copy link
Member

zulipbot commented Nov 7, 2022

@sofbe You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@sofbe
Copy link
Collaborator

sofbe commented Nov 9, 2022

I am still working on this issue.

sofbe added a commit to sofbe/zulip that referenced this issue Nov 11, 2022
Messages sent without a topic is now displayed as going
to "general chat".

Update tests to work with the renaming.

Fixes zulip#23291.
sofbe added a commit to sofbe/zulip that referenced this issue Nov 11, 2022
This adds a migration to update existing "(no topic)" objects
to "general chat".

Fixes zulip#23291.
@peterwang06
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @peterwang06! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@peterwang06
Copy link
Collaborator

@zulipbot abandon

sofbe added a commit to sofbe/zulip that referenced this issue Dec 7, 2022
Messages sent without a topic is now displayed as going
to "general chat".

Update tests to work with the renaming.

Fixes zulip#23291.
@HemantUmre12 HemantUmre12 removed their assignment Mar 10, 2023
@dmatovic
Copy link
Collaborator

@zulipbot claim

@dmatovic dmatovic removed their assignment Apr 13, 2023
@alya
Copy link
Contributor Author

alya commented May 1, 2023

Removing the "help wanted" tag, as the planned implementation is complex, and will require a core contributor to pick this up. Related discussion on CZO.

@alya alya added difficult Issues which we expect to be quite difficult and removed help wanted labels May 1, 2023
Joelute added a commit to Joelute/zulip that referenced this issue Jun 12, 2023
As plans to make it easier for new users to pick a topic and help with the
onboarding process, we want to rename the default topic "(no topic)" to
"general chat" for the messages sent without a topic.

Previously, when topics are required to send a message for an organization,
(no topic) was no longer an option as a topic name. With the rename, this
restriction has been removed.

Fixes: zulip#23291.
Joelute added a commit to Joelute/zulip that referenced this issue Jun 12, 2023
As plans to make it easier for new users to pick a topic and help with the
onboarding process, we want to rename the default topic "(no topic)" to
"general chat" for the messages sent without a topic.

Previously, when topics are required to send a message for an organization,
(no topic) was no longer an option as a topic name. With the rename, this
restriction has been removed.

Fixes: zulip#23291.
Joelute added a commit to Joelute/zulip that referenced this issue Jun 12, 2023
As plans to make it easier for new users to pick a topic and help with the
onboarding process, we want to rename the default topic "(no topic)" to
"general chat" for the messages sent without a topic.

Previously, when topics are required to send a message for an organization,
(no topic) was no longer an option as a topic name. With the rename, this
restriction has been removed.

Fixes: zulip#23291.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 22, 2025
This commit is a part of the work to support empty
string as a topic name.

Previously, empty string was not a valid topic name.

Adds `allow_empty_topic_name` boolean parameter to
`GET /users/me/{stream_id}/topics` endpoint to decide
whether the topic names in the fetched `topics` array
can be empty strings.

If False, the topic names in the fetched response will
have the value of `realm_empty_topic_display_name` field
in `POST /register` response replacing "".

Fixes part of zulip#23291.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 22, 2025
This commit is a part of the work to support empty
string as a topic name.

Previously, empty string was not a valid topic name.

Adds `allow_empty_topic_name` boolean parameter to
`GET /users/me/{stream_id}/topics` endpoint to decide
whether the topic names in the fetched `topics` array
can be empty strings.

If False, the topic names in the fetched response will
have the value of `realm_empty_topic_display_name` field
in `POST /register` response replacing "".

Fixes part of zulip#23291.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 22, 2025
This commit is a part of the work to support empty
string as a topic name.

Previously, empty string was not a valid topic name.

Adds `allow_empty_topic_name` boolean parameter to
`GET /users/me/{stream_id}/topics` endpoint to decide
whether the topic names in the fetched `topics` array
can be empty strings.

If False, the topic names in the fetched response will
have the value of `realm_empty_topic_display_name` field
in `POST /register` response replacing "".

Fixes part of zulip#23291.
timabbott pushed a commit that referenced this issue Jan 22, 2025
This commit is a part of the work to support empty
string as a topic name.

Previously, empty string was not a valid topic name.

Adds `allow_empty_topic_name` boolean parameter to
`GET /users/me/{stream_id}/topics` endpoint to decide
whether the topic names in the fetched `topics` array
can be empty strings.

If False, the topic names in the fetched response will
have the value of `realm_empty_topic_display_name` field
in `POST /register` response replacing "".

Fixes part of #23291.
ritwik-69 pushed a commit to ritwik-69/zulip that referenced this issue Jan 23, 2025
This commit is a part of the work to support empty
string as a topic name.

Previously, empty string was not a valid topic name.

Adds `allow_empty_topic_name` boolean parameter to
`GET /users/me/{stream_id}/topics` endpoint to decide
whether the topic names in the fetched `topics` array
can be empty strings.

If False, the topic names in the fetched response will
have the value of `realm_empty_topic_display_name` field
in `POST /register` response replacing "".

Fixes part of zulip#23291.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
7 participants