-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "(no topic)" to "general chat" #23291
Comments
Hello @zulip/server-misc, @zulip/server-onboarding members, this issue was labeled with the "area: onboarding", "area: topics" labels, so you may want to check it out! |
@zulipbot claim |
Messages sent without a topic is now displayed as going to "general chat". Fixes zulip#23291.
Messages sent without a topic is now displayed as going to "general chat". Update tests to work with the renaming. Fixes zulip#23291.
Messages sent without a topic is now displayed as going to "general chat". Update tests to work with the renaming. Fixes zulip#23291.
Messages sent without a topic is now displayed as going to "general chat". Update tests to work with the renaming. Fixes zulip#23291.
@sofbe You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
I am still working on this issue. |
Messages sent without a topic is now displayed as going to "general chat". Update tests to work with the renaming. Fixes zulip#23291.
This adds a migration to update existing "(no topic)" objects to "general chat". Fixes zulip#23291.
@zulipbot claim |
Welcome to Zulip, @peterwang06! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
@zulipbot abandon |
Messages sent without a topic is now displayed as going to "general chat". Update tests to work with the renaming. Fixes zulip#23291.
@zulipbot claim |
Removing the "help wanted" tag, as the planned implementation is complex, and will require a core contributor to pick this up. Related discussion on CZO. |
As plans to make it easier for new users to pick a topic and help with the onboarding process, we want to rename the default topic "(no topic)" to "general chat" for the messages sent without a topic. Previously, when topics are required to send a message for an organization, (no topic) was no longer an option as a topic name. With the rename, this restriction has been removed. Fixes: zulip#23291.
As plans to make it easier for new users to pick a topic and help with the onboarding process, we want to rename the default topic "(no topic)" to "general chat" for the messages sent without a topic. Previously, when topics are required to send a message for an organization, (no topic) was no longer an option as a topic name. With the rename, this restriction has been removed. Fixes: zulip#23291.
As plans to make it easier for new users to pick a topic and help with the onboarding process, we want to rename the default topic "(no topic)" to "general chat" for the messages sent without a topic. Previously, when topics are required to send a message for an organization, (no topic) was no longer an option as a topic name. With the rename, this restriction has been removed. Fixes: zulip#23291.
This commit is a part of the work to support empty string as a topic name. Previously, empty string was not a valid topic name. Adds `allow_empty_topic_name` boolean parameter to `GET /users/me/{stream_id}/topics` endpoint to decide whether the topic names in the fetched `topics` array can be empty strings. If False, the topic names in the fetched response will have the value of `realm_empty_topic_display_name` field in `POST /register` response replacing "". Fixes part of zulip#23291.
This commit is a part of the work to support empty string as a topic name. Previously, empty string was not a valid topic name. Adds `allow_empty_topic_name` boolean parameter to `GET /users/me/{stream_id}/topics` endpoint to decide whether the topic names in the fetched `topics` array can be empty strings. If False, the topic names in the fetched response will have the value of `realm_empty_topic_display_name` field in `POST /register` response replacing "". Fixes part of zulip#23291.
This commit is a part of the work to support empty string as a topic name. Previously, empty string was not a valid topic name. Adds `allow_empty_topic_name` boolean parameter to `GET /users/me/{stream_id}/topics` endpoint to decide whether the topic names in the fetched `topics` array can be empty strings. If False, the topic names in the fetched response will have the value of `realm_empty_topic_display_name` field in `POST /register` response replacing "". Fixes part of zulip#23291.
This commit is a part of the work to support empty string as a topic name. Previously, empty string was not a valid topic name. Adds `allow_empty_topic_name` boolean parameter to `GET /users/me/{stream_id}/topics` endpoint to decide whether the topic names in the fetched `topics` array can be empty strings. If False, the topic names in the fetched response will have the value of `realm_empty_topic_display_name` field in `POST /register` response replacing "". Fixes part of #23291.
This commit is a part of the work to support empty string as a topic name. Previously, empty string was not a valid topic name. Adds `allow_empty_topic_name` boolean parameter to `GET /users/me/{stream_id}/topics` endpoint to decide whether the topic names in the fetched `topics` array can be empty strings. If False, the topic names in the fetched response will have the value of `realm_empty_topic_display_name` field in `POST /register` response replacing "". Fixes part of zulip#23291.
At present, messages sent without a topic are displayed as going to "(no topic)". As discussed on CZO, we should make sending messages without a topic feel more normal/expected by renaming "(no topic)" to "general chat".
We want to have the server start allowing channel messages to have an empty topic at the API level, replacing the old "(no topic)" behavior. This should be displayed as something like "general chat" — with italics — in the UI.
The exact phrase to use for "general chat" is specified by the server in the API. For compatibility with old clients, the feature is gated by a flag the client sends. For details, see references below.
##References
Notes
Help center
/help/configure-who-can-edit-topics.md
and/help/require-topics.md
will need to be updated accordingly.The text was updated successfully, but these errors were encountered: