Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer "Mark topic as read" in topic action sheet #1225

Open
chrisbobbe opened this issue Dec 27, 2024 · 5 comments · May be fixed by #1274
Open

Offer "Mark topic as read" in topic action sheet #1225

chrisbobbe opened this issue Dec 27, 2024 · 5 comments · May be fixed by #1274
Assignees
@lakshya1goel
Labels
beta feedback Things beta users have specifically asked for help wanted
Milestone
M5: Launch

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 27, 2024 •
edited
Loading

In the legacy app, when a topic has unreads, we offer "Mark topic as read" in the topic action sheet. We should do that in zulip-flutter too.

Marking as "beta feedback" because this was requested for the (not yet built) channel action sheet on CZO:

In the channel list, a long press on the channel name should bring up a menu with options like "Mark all read" and "unsubscribe" and "copy link". That menu was available in the old app.

Related issues
@chrisbobbe chrisbobbe added the beta feedback Things beta users have specifically asked for label Dec 27, 2024
@chrisbobbe chrisbobbe mentioned this issue Dec 27, 2024
Open
@gnprice gnprice added this to the M6: Post-launch milestone Dec 28, 2024
@gnprice

This comment has been minimized.

Sign in to view
@AshutoshKhadse23

This comment has been minimized.

Sign in to view
@lakshya1goel
Copy link
Contributor

Hi, I have worked on this issue. Here is the screen recording for the same. Please assign the issue to me.

WhatsApp.Video.2025-01-07.at.6.51.04.PM.mp4

Also what icon should I use for this?

lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Jan 12, 2025
@lakshya1goel
Offer Mark topic as read in topic action sheet
21b7cd6 
Fixes: zulip#1225
@lakshya1goel lakshya1goel linked a pull request Jan 12, 2025 that will close this issue
Open
@gnprice gnprice modified the milestones: M6: Post-launch, M5: Launch Jan 14, 2025
@gnprice
Copy link
Member

gnprice commented Jan 22, 2025

Thanks @lakshya1goel! Assigned to you.

Also what icon should I use for this?

Good question. The place to ask that is in the #mobile-design channel. See details here:
https://zulip.readthedocs.io/en/latest/contributing/design-discussions.html#guidelines-for-code-contributors

(That section says #design, but for the mobile app the right channel is #mobile-design.)

lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Jan 30, 2025
@lakshya1goel
action_sheet: Add "Mark Topic As Read" button
56a877f 
Adds a new button to mark all messages in a topic as read. The button:
- Appears only when the topic has unread messages
- Uses mark_topic_as_read API for server feature level < 155
- Uses messages/flags/narrow API for server feature level >= 155
- Shows error dialog if the request fails

fixes: zulip#1225
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Jan 30, 2025
@lakshya1goel
action_sheet: Add "Mark Topic As Read" button
af14f10 
Adds button to mark all messages in a topic as read. The button:
- Appears only when the topic has unread messages
- Uses mark_topic_as_read API for server feature level < 155
- Uses messages/flags/narrow API for server feature level >= 155
- Shows error dialog if the request fails

fixes: zulip#1225
@lakshya1goel
Copy link
Contributor

Hello @gnprice, the PR is now ready for review, PTAL.
Thanks!

lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 1, 2025
@lakshya1goel
action_sheet: Add "Mark Topic As Read" button
7d8f4a4 
Adds button to mark all messages in a topic as read. The button:
- Appears only when the topic has unread messages
- Uses mark_topic_as_read API for server feature level < 155
- Uses messages/flags/narrow API for server feature level >= 155
- Shows error dialog if the request fails

fixes: zulip#1225
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 1, 2025
@lakshya1goel
action_sheet: Add "Mark Topic As Read" button
e45f627 
Adds button to mark all messages in a topic as read. The button:
- Appears only when the topic has unread messages
- Uses mark_topic_as_read API for server feature level < 155
- Uses messages/flags/narrow API for server feature level >= 155
- Shows error dialog if the request fails

fixes: zulip#1225
lakshya1goel added a commit to lakshya1goel/zulip-flutter that referenced this issue Feb 1, 2025
@lakshya1goel
action_sheet: Add "Mark Topic As Read" button
59fb9c2 
Adds button to mark all messages in a topic as read. The button:
- Appears only when the topic has unread messages
- Uses mark_topic_as_read API for server feature level < 155
- Uses messages/flags/narrow API for server feature level >= 155
- Shows error dialog if the request fails

fixes: zulip#1225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lakshya1goel lakshya1goel

Labels
beta feedback Things beta users have specifically asked for help wanted
Projects
Flutter app
Status: No status
Milestone
M5: Launch
Development

Successfully merging a pull request may close this issue.

action_sheet: Add "Mark Topic As Read" button lakshya1goel/zulip-flutter
4 participants
@gnprice @chrisbobbe @lakshya1goel @AshutoshKhadse23