Skip to content

Commit cd93194

Browse files
chrisbobbesm-sayedi
andcommitted
msglist: Hide content of muted messages, with a "Reveal message" button
Figma design: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=6089-28385&t=28DdYiTs6fXWR9ua-0 Co-authored-by: Sayed Mahmood Sayedi <[email protected]>
1 parent f71c5e9 commit cd93194

18 files changed

+266
-52
lines changed

assets/l10n/app_en.arb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1007,7 +1007,7 @@
10071007
"@noEarlierMessages": {
10081008
"description": "Text to show at the start of a message list if there are no earlier messages."
10091009
},
1010-
"revealButtonLabel": "Reveal message for muted sender",
1010+
"revealButtonLabel": "Reveal message",
10111011
"@revealButtonLabel": {
10121012
"description": "Label for the button revealing hidden message from a muted sender in message list."
10131013
},

assets/l10n/app_pl.arb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,10 +1089,6 @@
10891089
"@mutedSender": {
10901090
"description": "Name for a muted user to display in message list."
10911091
},
1092-
"revealButtonLabel": "Odsłoń wiadomość od wyciszonego użytkownika",
1093-
"@revealButtonLabel": {
1094-
"description": "Label for the button revealing hidden message from a muted sender in message list."
1095-
},
10961092
"mutedUser": "Wyciszony użytkownik",
10971093
"@mutedUser": {
10981094
"description": "Name for a muted user to display all over the app."

assets/l10n/app_ru.arb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,10 +1081,6 @@
10811081
"@mutedSender": {
10821082
"description": "Name for a muted user to display in message list."
10831083
},
1084-
"revealButtonLabel": "Показать сообщение отключенного отправителя",
1085-
"@revealButtonLabel": {
1086-
"description": "Label for the button revealing hidden message from a muted sender in message list."
1087-
},
10881084
"mutedUser": "Отключенный пользователь",
10891085
"@mutedUser": {
10901086
"description": "Name for a muted user to display all over the app."

lib/generated/l10n/zulip_localizations.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1502,7 +1502,7 @@ abstract class ZulipLocalizations {
15021502
/// Label for the button revealing hidden message from a muted sender in message list.
15031503
///
15041504
/// In en, this message translates to:
1505-
/// **'Reveal message for muted sender'**
1505+
/// **'Reveal message'**
15061506
String get revealButtonLabel;
15071507

15081508
/// Text to display in place of a muted user's name.

lib/generated/l10n/zulip_localizations_ar.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
820820
String get noEarlierMessages => 'No earlier messages';
821821

822822
@override
823-
String get revealButtonLabel => 'Reveal message for muted sender';
823+
String get revealButtonLabel => 'Reveal message';
824824

825825
@override
826826
String get mutedUser => 'Muted user';

lib/generated/l10n/zulip_localizations_de.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
820820
String get noEarlierMessages => 'No earlier messages';
821821

822822
@override
823-
String get revealButtonLabel => 'Reveal message for muted sender';
823+
String get revealButtonLabel => 'Reveal message';
824824

825825
@override
826826
String get mutedUser => 'Muted user';

lib/generated/l10n/zulip_localizations_en.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
820820
String get noEarlierMessages => 'No earlier messages';
821821

822822
@override
823-
String get revealButtonLabel => 'Reveal message for muted sender';
823+
String get revealButtonLabel => 'Reveal message';
824824

825825
@override
826826
String get mutedUser => 'Muted user';

lib/generated/l10n/zulip_localizations_ja.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
820820
String get noEarlierMessages => 'No earlier messages';
821821

822822
@override
823-
String get revealButtonLabel => 'Reveal message for muted sender';
823+
String get revealButtonLabel => 'Reveal message';
824824

825825
@override
826826
String get mutedUser => 'Muted user';

lib/generated/l10n/zulip_localizations_nb.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
820820
String get noEarlierMessages => 'No earlier messages';
821821

822822
@override
823-
String get revealButtonLabel => 'Reveal message for muted sender';
823+
String get revealButtonLabel => 'Reveal message';
824824

825825
@override
826826
String get mutedUser => 'Muted user';

lib/generated/l10n/zulip_localizations_pl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,7 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
833833
String get noEarlierMessages => 'Brak historii';
834834

835835
@override
836-
String get revealButtonLabel => 'Odsłoń wiadomość od wyciszonego użytkownika';
836+
String get revealButtonLabel => 'Reveal message';
837837

838838
@override
839839
String get mutedUser => 'Wyciszony użytkownik';

lib/generated/l10n/zulip_localizations_ru.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -835,7 +835,7 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
835835
String get noEarlierMessages => 'Предшествующих сообщений нет';
836836

837837
@override
838-
String get revealButtonLabel => 'Показать сообщение отключенного отправителя';
838+
String get revealButtonLabel => 'Reveal message';
839839

840840
@override
841841
String get mutedUser => 'Отключенный пользователь';

lib/generated/l10n/zulip_localizations_sk.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -822,7 +822,7 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
822822
String get noEarlierMessages => 'No earlier messages';
823823

824824
@override
825-
String get revealButtonLabel => 'Reveal message for muted sender';
825+
String get revealButtonLabel => 'Reveal message';
826826

827827
@override
828828
String get mutedUser => 'Muted user';

lib/generated/l10n/zulip_localizations_uk.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,7 @@ class ZulipLocalizationsUk extends ZulipLocalizations {
834834
String get noEarlierMessages => 'Немає попередніх повідомлень';
835835

836836
@override
837-
String get revealButtonLabel => 'Reveal message for muted sender';
837+
String get revealButtonLabel => 'Reveal message';
838838

839839
@override
840840
String get mutedUser => 'Muted user';

lib/generated/l10n/zulip_localizations_zh.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ class ZulipLocalizationsZh extends ZulipLocalizations {
820820
String get noEarlierMessages => 'No earlier messages';
821821

822822
@override
823-
String get revealButtonLabel => 'Reveal message for muted sender';
823+
String get revealButtonLabel => 'Reveal message';
824824

825825
@override
826826
String get mutedUser => 'Muted user';

lib/widgets/action_sheet.dart

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -589,6 +589,8 @@ void showMessageActionSheet({required BuildContext context, required Message mes
589589
final markAsUnreadSupported = store.zulipFeatureLevel >= 155; // TODO(server-6)
590590
final showMarkAsUnreadButton = markAsUnreadSupported && isMessageRead;
591591

592+
final isSenderMuted = store.isUserMuted(message.senderId);
593+
592594
final optionButtons = [
593595
if (popularEmojiLoaded)
594596
ReactionButtons(message: message, pageContext: pageContext),
@@ -597,6 +599,8 @@ void showMessageActionSheet({required BuildContext context, required Message mes
597599
QuoteAndReplyButton(message: message, pageContext: pageContext),
598600
if (showMarkAsUnreadButton)
599601
MarkAsUnreadButton(message: message, pageContext: pageContext),
602+
if (isSenderMuted)
603+
UnrevealMutedMessageButton(message: message, pageContext: pageContext),
600604
CopyMessageTextButton(message: message, pageContext: pageContext),
601605
CopyMessageLinkButton(message: message, pageContext: pageContext),
602606
ShareButton(message: message, pageContext: pageContext),
@@ -902,6 +906,27 @@ class MarkAsUnreadButton extends MessageActionSheetMenuItemButton {
902906
}
903907
}
904908

909+
class UnrevealMutedMessageButton extends MessageActionSheetMenuItemButton {
910+
UnrevealMutedMessageButton({
911+
super.key,
912+
required super.message,
913+
required super.pageContext,
914+
});
915+
916+
@override
917+
IconData get icon => ZulipIcons.eye_off;
918+
919+
@override
920+
String label(ZulipLocalizations zulipLocalizations) {
921+
return zulipLocalizations.actionSheetOptionHideMutedMessage;
922+
}
923+
924+
@override
925+
void onPressed() {
926+
findMessageListPage().unrevealMutedMessage(message.id);
927+
}
928+
}
929+
905930
class CopyMessageTextButton extends MessageActionSheetMenuItemButton {
906931
CopyMessageTextButton({super.key, required super.message, required super.pageContext});
907932

0 commit comments

Comments
 (0)