Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add result to librg_init #14

Closed
markatk opened this issue Jul 1, 2019 · 2 comments · Fixed by #15
Closed

Add result to librg_init #14

markatk opened this issue Jul 1, 2019 · 2 comments · Fixed by #15

Comments

@markatk
Copy link
Contributor

markatk commented Jul 1, 2019

When initializing enet fails (for example due to an already bound port on server side), the librg_init function does not give any result about it (except from the assert message). It would be nice to change the function to return a result or state so programs can do proper error management.
@markatk
Copy link
Contributor Author

markatk commented Jul 1, 2019

I am sorry, I messed up the function. The port failure is happening in librg_network_start. But nevertheless both functions (and i think some more others) could benefit from returned results.

@inlife
Copy link
Member

inlife commented Jul 2, 2019

i agree, those additions would be quite useful

@markatk markatk mentioned this issue Jul 2, 2019
Merged
@inlife inlife closed this as completed in #15 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add return values to failable functions
2 participants
@inlife @markatk