New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue about the attention block #26

Open

xuanxh1 opened this issue Jul 6, 2023 · 0 comments

xuanxh1 commented Jul 6, 2023

in attention paper, W = QK^T, right? However, in this implementation. W = Q^TW. is there something wrong?

the image above is the original code in this implementation.

and the second one is the correct way I thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment