-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to edit/delete text annotations on page #182
Comments
…182. Fixing color edit and tag edits being ignored for all annotation sometimes on phones. Refactoring of PdfAnnotation rows. Upping versionCode to 118
On iOS editing options for text annotation is implemented in the following way:
I don’t think it makes sense Android style-wise to implement it in a similar way, so instead I did it in the way that is most similar to how annotation editing works for other annotations, but with a caveat:
Why annotation has to be deselected first and why is it a long press? |
I think long-press is going to be very hard for people to find. Are we able to show anything after a single press? Even some sort of floating "Edit" button or something? |
Currently it seems like this is only possible in the sidebar. On iOS, we create a custom toolbar on tap that lets you adjust font size (awkwardly — it should probably be a slider that updates an editable textbox) and color, add tags, and delete the annotation.
The text was updated successfully, but these errors were encountered: