Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classification.metadata.userAgent records outdated information #6666

Open
eatyourgreens opened this issue Feb 5, 2025 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Feb 5, 2025

userAgent: types.optional(types.string, navigator.userAgent),

Package

  • lib-classifier

Is your feature request related to a problem? Please describe.

navigator.userAgent was frozen in Chrome 101 and replaced with the Client Hints API (navigator.userAgentData.)

Describe the solution you'd like

Since 2022, classifications should use the Client Hints API to get detailed information about Chrome and Edge. Safari and Firefox also have user-agent reduction, but unfortunately don't support the Client Hints API.

Additional context

@eatyourgreens eatyourgreens added the enhancement New feature or request label Feb 5, 2025
@eatyourgreens
Copy link
Contributor Author

It’s entirely possible that the reduced user-agent is fine for classification purposes, in which case ignore this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant