Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsidian callouts are broken in output #328

Open
ryanisaacg opened this issue Jan 11, 2025 · 1 comment · May be fixed by #330
Open

Obsidian callouts are broken in output #328

ryanisaacg opened this issue Jan 11, 2025 · 1 comment · May be fixed by #330

Comments

@ryanisaacg
Copy link

Source:

> [!NOTE] Title
> Body goes here

Result:

 > 
 > \[!NOTE\] Title
 > Body goes here

Expected result would look identical to source.

It looks like this was a known issue that couldn't be fixed because of lack of support for CommonMark. However, it seems like there is some support for this syntax in pulldown-cmark?.

I'd be happy to write a PR to preserve the original callout syntax during conversion if it would be welcome.

@zoni
Copy link
Owner

zoni commented Jan 14, 2025

I'd be happy to write a PR to preserve the original callout syntax during conversion if it would be welcome.

That would definitely be welcome, provided there's tests to go along with it 😄 (CONTRIBUTING has some pointers)

Might take me a while to review it or get back to you though, life is keeping me pretty busy at the moment

@ryanisaacg ryanisaacg linked a pull request Jan 16, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants