This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
SqsConnector #108
Closed
SqsConnector #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianfilip
reviewed
Nov 20, 2022
| @@ -0,0 +1,8 @@ | |||
| import sbt._ | |||
There was a problem hiding this comment.
We should use the latest version of aws sdk. https://github.com/zio/zio-connect/blob/master/project/AWSLambdaDependencies.scala
There was a problem hiding this comment.
I we should use zio-aws and build this connector on top of it. https://github.com/zio/zio-aws
There was a problem hiding this comment.
It's currently using the same versions as the S3 package. Maybe they should both be upgraded together? Or would you rather I update this one?
adrianfilip
reviewed
Nov 20, 2022
connectors/sqs-connector/src/main/scala/zio/connect/sqs/SqsConnector.scala
Show resolved
Hide resolved
|
Hi @xplosunn I think we can merge this after you get the tests to pass. |
|
@adrianfilip sorry for the delay. Just updated the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106