Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NestedTensor from pre-processing #471

Open
zhiqwang opened this issue Dec 23, 2022 · 0 comments
Open

Remove NestedTensor from pre-processing #471

zhiqwang opened this issue Dec 23, 2022 · 0 comments
Labels
code quality Code format and unit tests enhancement New feature or request

Comments

@zhiqwang
Copy link
Owner

zhiqwang commented Dec 23, 2022 •
edited
Loading

Anyway the error suggests that the issue could be resolved by moving NestedTestor to a pytorch class, if it works would you accept a PR on that?

Originally posted by @gillpeacegood in #469 (reply in thread)

Actually there are some historical reasons for the existence of NestedTensor, which is not required since #293 was merged. I guess there's some way to not rely upon NestedTensor for the pre-processing.

https://github.com/zhiqwang/yolov5-rt-stack/blob/1043ee3eacd8218c39e324c39693e373daf29a09/yolort/models/transform.py#L13-L20
@zhiqwang zhiqwang added enhancement New feature or request code quality Code format and unit tests labels Dec 23, 2022
@zhiqwang zhiqwang mentioned this issue Feb 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Code format and unit tests enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhiqwang