Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "-p" in gl_server usage text #38

Open
mikini opened this issue Jan 13, 2017 · 0 comments
Open

Missing "-p" in gl_server usage text #38

mikini opened this issue Jan 13, 2017 · 0 comments

Comments

@mikini
Copy link
Contributor

mikini commented Jan 13, 2017

When experimenting with the issue in #37 I was puzzled that gl_server didn't respect port number on the command line as instructed by the usage/help text which indicated it should be 4th argument .

~/openpixelcontrol$ bin/gl_server --help
Usage: bin/gl_server <options> -l <filename.json> [<port>]
miki@vcas-miki2:~/openpixelcontrol$ bin/gl_server -l layouts/freespace.json 7890
Loaded "layouts/freespace.json" as channel 1 (625 shapes)
OPC: Listening on port 21984

Inspecting the source revealed that a "-p" is expected, so the help text should be something like (there are only l and p options);

Usage: bin/gl_server -l <filename.json> [-p <port>]

Also it would be courteous to indicate an unknown/unused option on the command line instead of ignoring it completely as is the case currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant