Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superglue #10

Merged
merged 13 commits into from
Sep 16, 2021
Merged

Superglue #10

merged 13 commits into from
Sep 16, 2021

Conversation

yalov
Copy link

@yalov yalov commented Sep 14, 2021 •
edited
Loading

fixes #5

@zer0Kerbal zer0Kerbal self-requested a review September 14, 2021 17:42
@zer0Kerbal zer0Kerbal self-assigned this Sep 14, 2021
@zer0Kerbal zer0Kerbal added this to the Kaboom Super Gluing milestone Sep 14, 2021
@zer0Kerbal zer0Kerbal linked an issue Sep 14, 2021 that may be closed by this pull request
"Glued Kaboom" aka Kaboom Cryowelding or Kyanoacrylate #5
Closed
zer0Kerbal
zer0Kerbal reviewed Sep 14, 2021
View reviewed changes
source/Kaboom.cs Outdated
@@ -28,23 +28,21 @@ public class ModuleKaboom : PartModule
[KSPField(isPersistant = true)]
public bool isGlued = false;

[KSPField(guiName = "Superglue", guiActive = true, guiActiveEditor = true, groupName = "Kaboom")]
[KSPField(isPersistant = true, guiName = "Superglue", guiActive = true, guiActiveEditor = true, groupName = "Kaboom")]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yalov "Superglue it" love it - keeps up the kampy/cheeky/not taking itself too seriously attitude of KaboOom!

@yalov
Copy link
Author

yalov commented Sep 14, 2021

works in the simple stack
https://streamable.com/r8xj6m

@yalov
Copy link
Author

yalov commented Sep 14, 2021 •
edited
Loading

guiActiveUncommand makes KSPEvent active for incontrollable vessels, like debris tank

@yalov
Copy link
Author

yalov commented Sep 14, 2021

https://streamable.com/1kx1km
check and demand parts, attached to nodes

@yalov
Copy link
Author

yalov commented Sep 15, 2021

I put the red color of the cover in the settings, but I don't really like it, and prefer to leave only normal text cover and remove this setting, what do you think?

@zer0Kerbal
Copy link
Owner

zer0Kerbal commented Sep 15, 2021 •
edited
Loading

I put the red color of the cover in the settings, but I don't really like it, and prefer to leave only normal text cover and remove this setting, what do you think?

I was going to put an option (might already be there) for Colored PAW in Game Settings. That way you can have it colored or not. Easy enough to do, done it elsewhere. 🎙️

you got it - I like color - yet some don't. shrug to each their own play styles and preferences, so I always try to give options. 🗡️

zer0Kerbal
zer0Kerbal approved these changes Sep 15, 2021
View reviewed changes
Copy link
Owner

@zer0Kerbal zer0Kerbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking - well, better than if you superglued it.

zer0Kerbal
zer0Kerbal approved these changes Sep 15, 2021
View reviewed changes
Copy link
Owner

@zer0Kerbal zer0Kerbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will localize the settings later.

zer0Kerbal
zer0Kerbal approved these changes Sep 15, 2021
View reviewed changes
Copy link
Owner

@zer0Kerbal zer0Kerbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yalov yalov changed the title wip Superglue Superglue Sep 16, 2021
zer0Kerbal
zer0Kerbal approved these changes Sep 16, 2021
View reviewed changes
Copy link
Owner

@zer0Kerbal zer0Kerbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please tell me when you feel comfortable enough with the changes that I can compile a semi-public beta test.

@yalov
Copy link
Author

yalov commented Sep 16, 2021

It is ready for test

@zer0Kerbal zer0Kerbal merged commit 0ea9508 into zer0Kerbal:Dev-KaboomSuperglue Sep 16, 2021
@zer0Kerbal zer0Kerbal linked an issue Sep 17, 2021 that may be closed by this pull request
✨Kabooming of parts via staging.✨ #1
Open
2 tasks
@zer0Kerbal
Copy link
Owner

Version 1.3.99.0 - BETA!-1 - New Feature
@zer0Kerbal zer0Kerbal released this 21 seconds ago

Mod Version
KSP version KSP-AVC License GPLv2
Code Validate AVC .version files

Version 1.3.99.0 - BETA!
DO A CLEAN INSTALL: DELETE EXISTING THEN RE-INSTALL

BETA SOFTWARE - CAVEAT EMPTOR
⬇️ Download the .dll on Curseforge here.
New Feature: Kyanoacrylate 🦸 🩹 🧷 4️⃣ 🚀
usual spring cleaning and automation

[source] update folder structure
@yalov
update to modern back-end automation

resolves issue #6

Update
recompile for KSP 1.12.2
update to .NET 4.7.2
update to C# 9.0
renamed ModuleKaboom.cs to Kaboom.cs
See Full Changelog for full details of changes
See Known Issues for known issues

red box below is a link to forum post on how to get support
How to get support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zer0Kerbal zer0Kerbal zer0Kerbal approved these changes

Assignees

@yalov yalov

@zer0Kerbal zer0Kerbal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨Kabooming of parts via staging.✨ "Glued Kaboom" aka Kaboom Cryowelding or Kyanoacrylate
2 participants
@yalov @zer0Kerbal