rtio: Callback chaining and testing #72765
Open
+221
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teburd
force-pushed
the
rtio_callback_chaining
branch
from
28307bb
to
1666c2e
Compare
|
Converted back to draft as twister revealed a few issues still on certain platforms |
teburd
force-pushed
the
rtio_callback_chaining
branch
from
1666c2e
to
2f6b31e
Compare
|
Update: ok I believe I've corrected the issue, though the behavior is as it was before, I'm wondering if this is the right behavior @yperess Imagine I have 3 chained submissions and cancel the one in the middle before submit is called, the first one should report success, the next two should be cancelled, should they report anything? I guess more critically, why is cancelling before submit a special case, can you help clarify this @yperess? Thanks! |
Callbacks were a bit neglected in terms of test coverage, especially when used in chains. It was clear from the code that chained callbacks may not actually work, and callback ordering then was hard to verify. Test callbacks chained to transactions work as expected. The test iodev had built up some cruft over time and in the process showed a few bugs once callback chaining was fixed so the test iodev now better matches typical iodev implementations at this point. Cancellation testing now includes an added case for cancelling a the second submission in the chain prior to calling submit noting that no completions notifications should be given back for those. Signed-off-by: Tom Burdick <[email protected]>
teburd
force-pushed
the
rtio_callback_chaining
branch
from
2f6b31e
to
a2b8360
Compare
yperess
approved these changes
May 28, 2024
ubieda
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callbacks were a bit neglected in terms of test coverage, especially when used in chains. It was clear from the code that chained callbacks may not actually work, and callback ordering then was hard to verify. Test callbacks chained to transactions work as expected.
The test iodev had built up some cruft over time and in the process showed a few bugs once callback chaining was fixed so the test iodev now better matches typical iodev implementations at this point.
Fixes #72740