Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: ISO: Replace BT_ISO_STATE_ENCRYPT_PENDING with a flag #72722

Open
Thalley opened this issue May 14, 2024 · 0 comments
Open

Bluetooth: ISO: Replace BT_ISO_STATE_ENCRYPT_PENDING with a flag #72722

Thalley opened this issue May 14, 2024 · 0 comments
Assignees
Labels
area: API Changes to public APIs area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth Enhancement Changes/Updates/Additions to existing features

Comments

@Thalley
Copy link
Collaborator

Thalley commented May 14, 2024

Is your enhancement proposal related to a problem? Please describe.
An ISO channel today has a state called BT_ISO_STATE_ENCRYPT_PENDING which isn't really a state, but rather a dependency before it can leave the BT_ISO_STATE_DISCONNECTED state.

The issue with BT_ISO_STATE_ENCRYPT_PENDING is that it blocks the CIS from connecting (and rightfully so), but that also means that an ISO channel will go

  1. BT_ISO_STATE_DISCONNECTED
  2. BT_ISO_STATE_ENCRYPT_PENDING
  3. BT_ISO_STATE_DISCONNECTED
  4. BT_ISO_STATE_CONNECTING
  5. BT_ISO_STATE_CONNECTED

Instead of just

  1. BT_ISO_STATE_DISCONNECTED
  2. BT_ISO_STATE_CONNECTING
  3. BT_ISO_STATE_CONNECTED

Describe the solution you'd like
Remove the BT_ISO_STATE_ENCRYPT_PENDING and replace it with a flag in the ISO channel instead.

Describe alternatives you've considered
The alternative would be to create yet another state, BT_ISO_STATE_ENCRYPT_OK so that the channel will go

  1. BT_ISO_STATE_DISCONNECTED
  2. BT_ISO_STATE_ENCRYPT_PENDING
  3. BT_ISO_STATE_ENCRYPT_OK
  4. BT_ISO_STATE_CONNECTING
  5. BT_ISO_STATE_CONNECTED

Additional context
N/A

@Thalley Thalley added Enhancement Changes/Updates/Additions to existing features area: Bluetooth area: Bluetooth ISO Bluetooth LE Isochronous Channels labels May 14, 2024
@Thalley Thalley self-assigned this May 14, 2024
@Thalley Thalley added the area: API Changes to public APIs label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

No branches or pull requests

1 participant