Ambiq RTC differences #72480
-
Hello, @bjarki-trackunit! You are the maintainer for the RTC section.
This makes our implementation fail the most of the testing without additions to the tests. Do you think there is a better way to accomplish this? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
Regarding issue 1, returning -EINVAL is the correct behavior, and skipping the test if -EINVAL is returned is appropriate. Regarding issue 2, the test suite can be updated to set every supported field, rather than just hours and minutes. This is a valid configuration which should be supported by all RTCs. We can add an additional test to validate that only the selected alarm time fields are used, which is a valid configuration for most RTCs, this test can be skipped if the RTC returns -EINVAL, which would be the case for the AMBIQ RTC. |
Beta Was this translation helpful? Give feedback.
Regarding issue 1, returning -EINVAL is the correct behavior, and skipping the test if -EINVAL is returned is appropriate.
Regarding issue 2, the test suite can be updated to set every supported field, rather than just hours and minutes. This is a valid configuration which should be supported by all RTCs.
We can add an additional test to validate that only the selected alarm time fields are used, which is a valid configuration for most RTCs, this test can be skipped if the RTC returns -EINVAL, which would be the case for the AMBIQ RTC.