Skip to content

Conversation

@Json-Andriopoulos
Copy link
Contributor

@Json-Andriopoulos Json-Andriopoulos commented Nov 19, 2025

Describe changes

  • Moved heartbeat worker control to step runner (from step launcher).
  • Compilation layer changes to calculate heartbeat enabling flag

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • IMPORTANT: I made sure that my changes are reflected properly in the following resources:
    • ZenML Docs
    • Dashboard: Needs to be communicated to the frontend team.
    • Templates: Might need adjustments (that are not reflected in the template tests) in case of non-breaking changes and deprecations.
    • Projects: Depending on the version dependencies, different projects might get affected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

ZenML CLI Performance Comparison (Threshold: 1.0s, Timeout: 60s, Slow: 5s)

❌ Failed Commands on Current Branch (feature/4151-heartbeat-activation-logic)

  • zenml stack list: Command failed on run 1 (exit code: 1)
  • zenml pipeline list: Command failed on run 1 (exit code: 1)
  • zenml model list: Command failed on run 1 (exit code: 1)

🚨 New Failures Introduced

The following commands fail on your branch but worked on the target branch:

  • zenml stack list
  • zenml pipeline list
  • zenml model list

Performance Comparison

Command feature/heartbeat-prod-features Time (s) feature/4151-heartbeat-activation-logic Time (s) Difference Status
zenml --help 1.349239 ± 0.021024 1.332112 ± 0.007874 -0.017s ✓ No significant change
zenml model list Not tested Failed N/A ❌ Broken in current branch
zenml pipeline list Not tested Failed N/A ❌ Broken in current branch
zenml stack --help 1.307013 ± 0.013748 1.320469 ± 0.015297 +0.013s ✓ No significant change
zenml stack list Not tested Failed N/A ❌ Broken in current branch

Summary

  • Total commands analyzed: 5
  • Commands compared for timing: 2
  • Commands improved: 0 (0.0% of compared)
  • Commands degraded: 0 (0.0% of compared)
  • Commands unchanged: 2 (100.0% of compared)
  • Failed commands: 3 (NEW FAILURES INTRODUCED)
  • Timed out commands: 0
  • Slow commands: 0

Environment Info

  • Target branch: Linux 6.11.0-1018-azure
  • Current branch: Linux 6.11.0-1018-azure
  • Test timestamp: 2025-11-24T07:15:11Z
  • Timeout: 60 seconds
  • Slow threshold: 5 seconds

@github-actions github-actions bot added the enhancement New feature or request label Nov 19, 2025
@Json-Andriopoulos Json-Andriopoulos force-pushed the feature/4151-heartbeat-activation-logic branch 2 times, most recently from 212bfd8 to 871358b Compare November 19, 2025 10:44
@Json-Andriopoulos Json-Andriopoulos force-pushed the feature/4151-heartbeat-activation-logic branch 2 times, most recently from 25e4efc to d148b6f Compare November 24, 2025 10:18
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Documentation Link Check Results

Absolute links check failed
There are broken absolute links in the documentation. See workflow logs for details
Relative links check passed
Last checked: 2025-11-25 06:46:21 UTC

@Json-Andriopoulos Json-Andriopoulos added the run-slow-ci Tag that is used to trigger the slow-ci label Nov 24, 2025
@Json-Andriopoulos Json-Andriopoulos force-pushed the feature/4151-heartbeat-activation-logic branch from 8a9dfdc to 7927023 Compare November 25, 2025 06:43
@Json-Andriopoulos Json-Andriopoulos changed the base branch from feature/heartbeat-prod-features to develop November 25, 2025 06:44
@Json-Andriopoulos Json-Andriopoulos force-pushed the feature/4151-heartbeat-activation-logic branch from 7927023 to 9dcf1c4 Compare November 25, 2025 07:19
@Json-Andriopoulos Json-Andriopoulos merged commit dbcfe3f into develop Nov 25, 2025
56 of 64 checks passed
@Json-Andriopoulos Json-Andriopoulos deleted the feature/4151-heartbeat-activation-logic branch November 25, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request run-slow-ci Tag that is used to trigger the slow-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants