-
Notifications
You must be signed in to change notification settings - Fork 559
Adding step name to console logs #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes in the pull request modify the logging functionality in the StepLogsStorageContext class. The new update introduces the Changes
Sequence Diagram(s)sequenceDiagram
participant S as StepLogsStorageContext
participant GC as get_step_context
participant OS as Output Stream
S->>GC: Call get_step_context()
alt Context found
GC-->>S: Return step context (with step name)
S->>S: Check if message is not newline
S->>S: Prefix message with step name
else No context
GC-->>S: Return None
end
S->>OS: Write original or prefixed message
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/zenml/logging/step_logging.py(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`src/zenml/**/*.py`: Review the Python code for conformity with Python best practices.
src/zenml/**/*.py: Review the Python code for conformity with Python best practices.
src/zenml/logging/step_logging.py
🪛 GitHub Actions: ci-fast
src/zenml/logging/step_logging.py
[error] 1-1: Ruff formatting check failed. Would reformat: src/zenml/logging/step_logging.py. Run 'ruff format' to fix code style issues.
🔇 Additional comments (1)
src/zenml/logging/step_logging.py (1)
25-25: Added import for step context functionalityThe added import
get_step_contextis necessary for the implementation of step name prefixing in console logs.
Documentation Link Check Results✅ Absolute links check passed |
Describe changes
This PR adds the names of the steps in the console output if possible but not to the way that they are stored.
will return:
but at the same time, the actual logs on the dashboard side looks like:
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes
Summary by CodeRabbit