Skip to content

Fix version validation #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Fix version validation #3467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scripts/validate-new-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ IFS='.' read -r P_MAJOR P_MINOR P_PATCH <<< "$PLANNED_VERSION"
# List PRs merged after the latest release date and filter by breaking change label
PRS=$(gh pr list --search "is:merged merged:>$TAG_DATE label:$LABEL_BREAKING_CHANGE base:develop" --json number,title)

# Check if the PRs list for breaking changes is empty
if [ -z "$PRS" ]; then
# Check if there are any PRs with breaking changes
PR_COUNT=$(echo "$PRS" | jq '. | length')

if [ "$PR_COUNT" -eq 0 ]; then
IDEAL_NEW_VERSION="$MAJOR.$MINOR.$((PATCH + 1))"

# Warn in case of a mismatch
Expand All @@ -61,5 +63,4 @@ else
if [ "$PLANNED_VERSION" != "$IDEAL_NEW_VERSION" ]; then
echo "::warning::Warning: The new planned version '$PLANNED_VERSION' is not the same as the ideal version '$IDEAL_NEW_VERSION'. Please, make sure this '$PLANNED_VERSION' is selected on purpose."
fi

fi
Loading