Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reasoning behind best practices check #335

Open
onmomo opened this issue Dec 14, 2020 · 0 comments
Open

Improve reasoning behind best practices check #335

onmomo opened this issue Dec 14, 2020 · 0 comments

Comments

@onmomo
Copy link

onmomo commented Dec 14, 2020

Which version of kube-score are you using?

kube-score version: 1.10.0

What did you expect to see?

For some of the checks, especially for CRITICAL checks, I would like to have a more in-depth explanation about the reasoning behind them. Either in the docs or directly in the tool.
I also found it quite tricky to roll out the tool due to these missing resources.

eg
https://blog.colinbreck.com/kubernetes-liveness-and-readiness-probes-how-to-avoid-shooting-yourself-in-the-foot/

  • It should never, be the same as your readinessProbe.
    -> Couldn't find a source to bake this.
  • The livenessProbe should never depend on downstream dependencies, such as databases or other services.
    -> this is probably because checking a dependant service could take longer than the livenessProbe request timeout to return due to small network slips or increased load that would cause a chain reaction.

https://github.com/zegl/kube-score/blob/master/README_CHECKS.md

  • service-type
    -> security issue because of open ports on the node?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant