Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build testing of external plugins #3535

Open
awelzel opened this issue Jan 8, 2024 · 0 comments
Open

Add build testing of external plugins #3535

awelzel opened this issue Jan 8, 2024 · 0 comments

Comments

@awelzel
Copy link
Contributor

awelzel commented Jan 8, 2024

With #3354 we broke the OpaqueVal API for plugins without noticing. Prior breakage was failing to propagate OpenSSL include headers on OSX.

@ckreibich suggests

using a couple of external plugins for checking for build failures we introduce unwittingly. I was nervous in the past about relying on codebases we don't control for our own testing, but perhaps we should give it a go for now and see how it works over time.

Suggest to start with zeek-more-hashes (due to OpaqueVal usage and under our control) and the zeek-kafka plugin due to being popular and relatively stable, plus having third-party library dependencies.

Testing should be done using the Zeek installation tree on Linux and OSX (the latter being interesting due to some non-standard include paths for OpenSSL and other dependencies).

Alternatively, dumping a baseline of public zeek:: function signatures and classes with their public (and protected if class not final) methods could also provide some signal that we're causing an API break unwittingly.

Possibly https://lvc.github.io/abi-compliance-checker/ (used a long time ago by @bbannier)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant