You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #2746 , @rsmmr was wondering whether we should compile all of Zeek on all architectures with -funsigned-char or with -fsigned-char
The crux is that a bare char on x86 is signed, while on ARM it's unsigned.
Seems that forcing it to "unsigned" would be appropriate with the motivation that we generally deal with "bytes".
This has come up only recently for the Linux kernel and seems Linux 6.2 is now compiled with -funsigned-char. The LWN article has a bit more background.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
After #2746 , @rsmmr was wondering whether we should compile all of Zeek on all architectures with
-funsigned-char
or with-fsigned-char
The crux is that a bare
char
on x86 is signed, while on ARM it's unsigned.Seems that forcing it to "unsigned" would be appropriate with the motivation that we generally deal with "bytes".
This has come up only recently for the Linux kernel and seems Linux 6.2 is now compiled with
-funsigned-char
. The LWN article has a bit more background.https://lwn.net/Articles/911914/
Beta Was this translation helpful? Give feedback.
All reactions