Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed numbers encode differently from unsigned #5

Open
duffy-ocraven opened this issue Mar 7, 2022 · 1 comment
Open

Signed numbers encode differently from unsigned #5

duffy-ocraven opened this issue Mar 7, 2022 · 1 comment

Comments

@duffy-ocraven
Copy link

Lines 217-219 of asn1.spicy as

    ASN1Type::Integer,
    ASN1Type::Enumerated -> num_value: bytes &size=head.len.len
                                             &convert=$$.to_int(spicy::ByteOrder::Big);

haven't taken into account that signed numbers encode differently from unsigned. see zeek/spicy#137

@duffy-ocraven
Copy link
Author

https://ldap.com/ldapv3-wire-protocol-reference-asn1-ber/ is a thorough and helpful treatment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant