Allowing teachers to join other classrooms as students

[igawaclawska]

After discussing multiple classroom support functionality with @mircealungu, we realized that teachers should also be allowed to join other classrooms as students to practice languages. I have not tested it yet but for now I assume that in the frontend, It would be just removing the !user.is_teacher condition in the Settings.js:

        {!user.is_teacher && (
          <SettingsItem path={"/account_settings/current_class"}>
            {strings.myCurrentClass}
          </SettingsItem>
        )}

But would it be safe from the backend point of view? Would it require modifying the backend? Also, we probably don't want teachers to join their own classrooms as students.

[tfnribeiro]

I think teacher are already supported:

The current implementation, where the "Owner" of the class has to invite the colleagues seems good to me - but we could rework it so a teacher could join other teacher's invite codes.

[igawaclawska]

The current implementation, where the "Owner" of the class has to invite the colleagues seems good to me - but we could rework it so a teacher could join other teacher's invite codes.

I see. Do I understand correctly that they become additional teachers (and admins) of the classroom they joined?

[tfnribeiro]

Yes, they get the same permissions :)

[mircealungu]

@igawaclawska Indeed removing that condition should be fine. The backend will not be bothered.

And even being a student in your own class is not that dramatic. You can always unenroll if you don't want to see your own activity :) In fact, it might even be useful for a teacher who wants to test the platform. Before he adds students, he can enroll herself, read, do exercises, and then see what can she see in the teacher dashboard!