Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux. Crash when typing "--da" after having another CSS variable beginning with the same name #12022

Closed
1 task done
SyntheticBird45 opened this issue May 18, 2024 · 6 comments
Closed
1 task done

Linux. Crash when typing "--da" after having another CSS variable beginning with the same name #12022

SyntheticBird45 opened this issue May 18, 2024 · 6 comments
Labels
css CSS styling support defect [core label] language An umbrella label for all programming languages syntax behaviors linux panic / crash [core label]

Comments

@SyntheticBird45
Copy link

SyntheticBird45 commented May 18, 2024 •
edited

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I've a CSS file with a variable called --dark-bg-0. When I try to type --dark-bg-1, Zed crashes at --da.
possibly related to #11703

zed.mp4

Environment

Zed: v1.0.0 (Zed)
OS: Linux 1.0.0
Memory: 15.5 GiB
Architecture: x86_64

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

It seems like at each crash, the logs aren't synced to disk. There are no lines of the Zed instance I started.
@SyntheticBird45 SyntheticBird45 added admin read Pending admin review defect [core label] panic / crash [core label] triage Maintainer needs to classify the issue labels May 18, 2024
@SyntheticBird45 SyntheticBird45 changed the title Crash when typing "--da" after having another CSS variable beginning with the same name Linux. Crash when typing "--da" after having another CSS variable beginning with the same name May 18, 2024
@apricotbucket28
Copy link
Contributor

Duplicate of #11703
Btw, you seem to be running an old commit (no window decorations)

@SyntheticBird45
Copy link
Author

Btw, you seem to be running an old commit (no window decorations)

I literally just installed v0.135.2 from AUR 3 hours ago. I must admit its weird since I saw the Wayland drag and resize PR got merged but haven't seen it in the changelog. Is it pre-release?

@apricotbucket28
Copy link
Contributor

Btw, you seem to be running an old commit (no window decorations)

I literally just installed v0.135.2 from AUR 3 hours ago. I must admit its weird since I saw the Wayland drag and resize PR got merged but haven't seen it in the changelog. Is it pre-release?

Oh, that's the latest "stable" release. The newest changes are on the master branch. I'd suggest compiling it yourself instead of using the AUR, it's probably more stable to use the master branch on Linux anyway 😆

@SyntheticBird45
Copy link
Author

it's probably more stable to use the master branch on Linux anyway

got it. will do 👍

@github-actions github-actions bot mentioned this issue May 19, 2024
Open
@JosephTLyons JosephTLyons added linux css CSS styling support language An umbrella label for all programming languages syntax behaviors and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 19, 2024
@SyntheticBird45
Copy link
Author

any news ? bug still present in newer version

@apricotbucket28 apricotbucket28 mentioned this issue Jun 2, 2024
Merged
mikayla-maki pushed a commit that referenced this issue Jun 3, 2024
@apricotbucket28
cosmic_text: Handle variation selectors; fix emoji colors (#12587)
ed86b86 
Basically, we detect if a glyph is a variation selector if its `id` is 3
(i.e. a whitespace character) and if it comes from an emoji font (since
variation selectors are only used for emoji glyphs).

- Fixes #11703 and
#12022

Release Notes:

- N/A
@apricotbucket28
Copy link
Contributor

apricotbucket28 commented Jun 3, 2024 •
edited by notpeter

Fixed by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css CSS styling support defect [core label] language An umbrella label for all programming languages syntax behaviors linux panic / crash [core label]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikayla-maki @JosephTLyons @apricotbucket28 @SyntheticBird45