Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANO shape parameter of the left hand #50

Closed
mks0601 opened this issue Sep 13, 2024 · 3 comments
Closed

MANO shape parameter of the left hand #50

mks0601 opened this issue Sep 13, 2024 · 3 comments

Comments

@mks0601
Copy link

mks0601 commented Sep 13, 2024

Hi Alex, how are you doing?
Thanks for your great dataset.
It seems there is a problem in the MANO shape parameter of the left hand.

s01_box_grab_01_0_70_left_zero
The above is from left hand of s01 / box_grab_01 / 0 / 70.
I set all inputs to zero except the shape parameter, where MANO layer is initialized with flat_hand_mean=True for the visualization.
As you can see, although flat_hand_mean=True, finger is bent, which is caused by some weird MANO shape parameter.
This makes artifacts when posed like the below image.

s01_box_grab_01_0_70_left
This is from the same frame, but I passed all inputs to MANO layer including hand_pose.
As you can see, bent index finger becomes weird when posed.

I found that there is no problem for the right hand. Could you let me know why this happens?
BTW, do you know there is a bug in the shapedirs of the MANO left hand?
You can see the bug in here: vchoutas/smplx#48
Simply saying, when we pass the same shape parameter to the left/right MANO layer, output geometry looks very different.
We need to do mano_layer['left'].shapedirs[:,0,:] *= -1 fo fix this bug.
FYI, although I do mano_layer['left'].shapedirs[:,0,:] *= -1, I can't remove the bug. All the above figures are from MANO layer as it is without doing mano_layer['left'].shapedirs[:,0,:] *= -1.

@zc-alexfan
Copy link
Owner

zc-alexfan commented Sep 16, 2024

Hi Gyeongsik,

Thanks for reaching out! Yes, recently, I also realized there was a bug in MANO left hand shape space (therefore, ARCTIC was fitted with this buggy left hand shape space). Given CVPR deadline, I cannot rerun mosh to correct this. However, maybe you can fit MANO to the SMPLX mesh? Hope this will address the issue.

@mks0601
Copy link
Author

mks0601 commented Sep 17, 2024

Awesome. Thanks for checking. See you at ECCV :)

@zc-alexfan zc-alexfan pinned this issue Sep 18, 2024
@zc-alexfan zc-alexfan unpinned this issue Sep 18, 2024
@zc-alexfan zc-alexfan reopened this Sep 18, 2024
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants