misc: Add comment for failing tests in FIPS environments (facebookincubator#12188)

czentgr · facebook-github-bot · commit 68fcaa1193b2 · 2025-01-27T21:47:09.000-08:00
Summary: In FIPS enabled environments OpenSSL is restricting access to certain APIs due to them being insecure. Velox supports functions that calculate the results using these obsolete functions. The tests will fail if run. Pull Request resolved: facebookincubator#12188 Reviewed By: kgpai Differential Revision: D68746609 Pulled By: xiaoxmeng fbshipit-source-id: c428ea8cd7170436f784d9dbab96282150983f1f
diff --git a/velox/functions/prestosql/tests/BinaryFunctionsTest.cpp b/velox/functions/prestosql/tests/BinaryFunctionsTest.cpp
@@ -257,6 +257,8 @@ TEST_F(BinaryFunctionsTest, HmacSha512) {
   EXPECT_EQ(std::nullopt, hmacSha512(std::nullopt, "velox"));
 }
 
+// Note: this test fails in a FIPS enabled environment because OpenSSL restricts
+// usage of MD5 for hmacs.
 TEST_F(BinaryFunctionsTest, HmacMd5) {
   const auto hmacMd5 = [&](std::optional<std::string> arg,
                            std::optional<std::string> key) {

Original file line number	Diff line number	Diff line change
`@@ -257,6 +257,8 @@ TEST_F(BinaryFunctionsTest, HmacSha512) {`
`257`	`257`	`EXPECT_EQ(std::nullopt, hmacSha512(std::nullopt, "velox"));`
`258`	`258`	`}`
`259`	`259`
	`260`	`+// Note: this test fails in a FIPS enabled environment because OpenSSL restricts`
	`261`	`+// usage of MD5 for hmacs.`
`260`	`262`	`TEST_F(BinaryFunctionsTest, HmacMd5) {`
`261`	`263`	`const auto hmacMd5 = [&](std::optional<std::string> arg,`
`262`	`264`	`std::optional<std::string> key) {`