Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for storage classes #2693

Merged
merged 50 commits into from
Jan 25, 2025
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
2ea442c
Run Store tests on logging
maxrjones Jan 11, 2025
7f76575
Run store tests on wrapper
maxrjones Jan 11, 2025
98b7392
Add read only open tests to WrapperStore
maxrjones Jan 11, 2025
18be47f
Ignore new coverage files
maxrjones Jan 11, 2025
69ce1d7
Simplify wrapper tests
maxrjones Jan 11, 2025
5877355
Fix __eq__ method in WrapperStore
maxrjones Jan 11, 2025
b4310fd
Implement __repr__ for WrapperStore
maxrjones Jan 11, 2025
d08458e
Allow separate open and init kwargs
maxrjones Jan 11, 2025
f663694
Add open class method to LoggingStore
maxrjones Jan 11, 2025
cf62f67
Add __str__ to WrapperStore
maxrjones Jan 11, 2025
31f9931
Add repr test for LoggingStore
maxrjones Jan 11, 2025
964aeaa
Fix __eq__ in LoggingStore
maxrjones Jan 11, 2025
332f564
Test getsize for stores
maxrjones Jan 11, 2025
4d4d728
Test for invalid ByteRequest
maxrjones Jan 11, 2025
30d1323
Use stdout rather than stderr as the default logging stream
maxrjones Jan 12, 2025
9764204
Test default logging stream
maxrjones Jan 12, 2025
fefd666
Add test for getsize_prefix
maxrjones Jan 12, 2025
6f240c2
Document buffer prototype parameter
maxrjones Jan 12, 2025
d2bbd9d
Add test for invalid modes in StorePath.open()
maxrjones Jan 12, 2025
85f44db
Add test for contains_group
maxrjones Jan 12, 2025
51c0c15
Add tests for contains_array
maxrjones Jan 12, 2025
ddd6bc9
Test for invalid root type for LocalStore
maxrjones Jan 12, 2025
62a528c
Test LocalStore.get with default prototype
maxrjones Jan 12, 2025
5f00efd
Test for invalid set buffer arguments
maxrjones Jan 13, 2025
6923337
Test get and set on closed stores
maxrjones Jan 13, 2025
0792fa8
Test using stores in a context manager
maxrjones Jan 13, 2025
dd0de05
Specify abstract methods for StoreTests
maxrjones Jan 13, 2025
4dba40c
Apply suggestions from code review
maxrjones Jan 13, 2025
48abe94
Lint
maxrjones Jan 14, 2025
bf4589d
Fix typing for LoggingStore
maxrjones Jan 14, 2025
5b37417
Match specific Errors in tests
maxrjones Jan 14, 2025
74647de
Add docstring
maxrjones Jan 14, 2025
c8ebcd0
Parametrize tests
maxrjones Jan 14, 2025
1e96600
Test for contains group/array at multiple heirarchies
maxrjones Jan 14, 2025
cc14e07
Update TypeError on GpuMemoryStore
maxrjones Jan 14, 2025
5148dd6
Merge branch 'main' into testing-storage
maxrjones Jan 15, 2025
bf58808
Don't implement _is_open setter on wrapped stores
maxrjones Jan 16, 2025
e1caef0
Update reprs for LoggingStore and WrapperStore
maxrjones Jan 16, 2025
1922d2d
Test check_writeable and close for WrapperStore
maxrjones Jan 16, 2025
45ea40d
Update pull request template (#2717)
brokkoli71 Jan 16, 2025
b281bc9
Add release notes
maxrjones Jan 16, 2025
9a75da2
Merge branch 'main' into testing-storage
maxrjones Jan 16, 2025
ca83bd6
Merge branch 'main' into testing-storage
maxrjones Jan 23, 2025
0d6eccf
Comprehensive changelog entry
maxrjones Jan 23, 2025
9059135
Match error message
maxrjones Jan 23, 2025
1e080c0
Merge branch 'main' into testing-storage
maxrjones Jan 24, 2025
1587fd1
Apply suggestions from code review
maxrjones Jan 24, 2025
5e16b3d
Update 2693.bugfix.rst
maxrjones Jan 24, 2025
128ef99
Merge branch 'main' into testing-storage
jhamman Jan 25, 2025
1faa66c
Merge branch 'main' into testing-storage
d-v-b Jan 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test for invalid root type for LocalStore
  • Loading branch information
maxrjones committed Jan 12, 2025
commit ddd6bc96459aaaa09e509f2f8c94ecf1601ba3d5
4 changes: 4 additions & 0 deletions tests/test_store/test_local.py
Original file line number Diff line number Diff line change
@@ -53,3 +53,7 @@ def test_creates_new_directory(self, tmp_path: pathlib.Path):

store = self.store_cls(root=target)
zarr.group(store=store)

def test_invalid_root_raises(self):
with pytest.raises(TypeError):
LocalStore(root=0)