Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make consolidated metadata fetch opt-in #2528

Open
dcherian opened this issue Dec 2, 2024 · 2 comments
Open

Make consolidated metadata fetch opt-in #2528

dcherian opened this issue Dec 2, 2024 · 2 comments
Labels
bug Potential issues with the zarr-python library

Comments

@dcherian
Copy link
Contributor

dcherian commented Dec 2, 2024

Zarr version

main

Numcodecs version

...

Python Version

...

Operating System

...

Installation

...

Description

Icechunk for example, does not implement this and these requests are wasted gets/sets. Stores should opt-in to this behaviour

Steps to reproduce

...

Additional output

No response

@dcherian dcherian added bug Potential issues with the zarr-python library V3 labels Dec 2, 2024
@TomAugspurger
Copy link
Contributor

TomAugspurger commented Dec 2, 2024

Stores should opt-in to this behaviour

Probably opt-out, right? The current behavior, of use_consolidated=None, matches the behavior from V2, which is to use it if present. With something like Store.supports_consolidated_metadata, we could set use_consolidated=store.supports_consolidated_metadata and skip it when we know it can't be present.

And just a note: I think this only affects Zarr v2, since in Zarr v3 the consolidated metadata is in the same zarr.json as the other metadata.

@dcherian
Copy link
Contributor Author

dcherian commented Dec 2, 2024

Yes, now I think that the issue that motivated this comment is on the Xarray side: pydata/xarray#9848

@dstansby dstansby removed the V3 label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Potential issues with the zarr-python library
Projects
None yet
Development

No branches or pull requests

3 participants