-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow generating the config file through CLI params #880
Comments
That's an interesting idea. My concern is however, that I don't like passing passwords in clear text (whether it be via command line, webUI, or an app). But I'm not everyone ;) and I can see how others would find that functionality useful. Perhaps using the LAB_CORE_HOST, LAB_CORE_TOKEN, adding a LAB_CORE_USER variable, and then adding a --save-config option would be better than adding 3 separate parameters? What do you think? That way a user could do LAB_CORE_HOST=http://gitlab.com LAB_CORE_TOKEN=1234abcd LAB_CORE_USER=prarit lab --save-config and just have the information saved? |
Oh, in my case too I have the token in a shell variable, but we can't control how people use it, because there is not way to tell shell replacements and direct strings apart AFAIK. For 3 params (config with options) vs single Also, if there's a need to only change the
And it goes and updates only the token value, and retains the other values. |
Hi, thanks for this awesome tool.
I have a recommendation that I would also be willing to take a stab at. Before that, I just want to pass this idea by for opinions:
In the fresh start section, it mentions a prompt based generation of lab.toml file. Do you think it is worth it to have something like:
Currently I have a template that I plug the values in for headless installation, but including the config command would make such configurations easier.
The text was updated successfully, but these errors were encountered: