Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ascanruels: Address SAST (Sonar) findings in SQLi Rule #6196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ascanruels: Address SAST (Sonar) findings in SQLi Rule #6196

wants to merge 1 commit into from

Conversation

kingthorin
Copy link
Member

Overview

  • CHANGELOG > Add maint note.
  • SqlInjectScanRule
    • Replace Arrays.asList with inline array declarations with List.of().
    • Change enum names to full caps.
    • Change static access to constants in abstract classes to use the base class.
    • Reduce newlines in some comment blocks.
    • Combine nested ifs.
    • Remove unnecessary return statement.
    • Extract a method for boolean based extra info. (Reduce repetition of string literal/code).
    • Correct array declarations (square brackets on type not name).
    • Extract constants for two multi-occurrence string literals.
    • Move counter from within loop to loop declaration.

Related Issues

n/a

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@kingthorin
ascanruels: Address SAST (Sonar) findings in SQLi Rule
14e5d37 
- CHANGELOG > Add maint note.
- SqlInjectScanRule
    - Replace Arrays.asList with inline array declarations with
List.of().
    - Change enum names to full caps.
    - Change static access to constants in abstract classes to use the
base class.
    - Reduce newlines in some comment blocks.
    - Combine nested ifs.
    - Remove unnecessary return statement.
    - Extract a method for boolean based extra info. (Reduce repetition
of string literal/code).
    - Correct array declarations (square brackets on type not name).
    - Extract constants for two multi-occurrence string literals.
    - Move counter from within loop to loop declaration.

Signed-off-by: kingthorin <[email protected]>
@psiinon
Copy link
Member

psiinon commented Feb 14, 2025

Logo
Checkmarx One – Scan Summary & Details – ef755bcb-7459-432b-8135-56dbb0d71c0d

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingthorin @psiinon