-
Notifications
You must be signed in to change notification settings - Fork 15
chore: Reshare secret keys 2 sets + trait revamp #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
01c6981 to
283b8db
Compare
Consolidated Tests Results 2025-11-27 - 16:40:58Test ResultsDetails
test-reporter: Run #1522
🎉 All tests passed!TestsView All Tests
🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
kc1212
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are mostly around visibility, otherwise LGTM!
|
BTW, was wondering should we return a |
No strong opinion here, but since we're using these MaybeExpected associat types for inputs, we might as well extend it to outputs |
Description of changes
Generalize the reshare of the private keyset to work with both same set and two sets reshare (using trait).
Add a trait system to try and make the use of reshare dumb proof as the functions are used by parties in different sets which are expected to provide different inputs.
Add the usual protocol trait system to reshare to be able to compose with various implementations of broadcast and robust open (will be useful for testing malicious strategies).
Issue ticket number and link
PR Checklist
I attest that all checked items are satisfied. Any deviation is clearly justified above.
chore: ...).TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + infra-team reviewer assigned.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.Dependency Update Questionnaire (only if deps changed or added)
Answer in the
Cargo.tomlnext to the dependency (or here if updating):More details and explanations for the checklist and dependency updates can be found in CONTRIBUTING.md