enableAccessLog filter actively disable routes that are not matched

[rgritti]

Describe the bug
Filter enableAccessLog with parameter, disables access logs of status codes that are not matched.

To Reproduce

1. set skipper.Options.AccessLogDisabled = false
2. add a route with -> enableAccessLog(4, 5)
3. make a requests that returns 2xx

Expected behavior
I expect to see the access logs

Observed behavior
Access logs for the request are not shown

[AlexanderYastrebov]

enableAccessLog overrides global Skipper AccessLogDisabled setting per route

[rgritti]

Right, but in my example above I have never explicitly disabled anything, but I end up with access logs for status codes 2xx disabled.

[szuecs]

@rgritti as far as I understand you set the default to log, but then you filter logging for the route to log only 4xx and 5xx.
So the behavior seems as you configured, not?

[rgritti]

@szuecs I think that if you enable the access logs globally, and then you enable specifically the 4xx and 5xx, you should see the 2xx as well, no?

but then you filter logging for the route to log only 4xx and 5xx

The only that you wrote is not clear from the filter name nor from the documentation.
I would at least expect that the documentation to say that enableAccessLog() disable the logs for everything that is not matched

[szuecs]

No, I think you should specify what you want to see, no inheritance!
We should make the docs more clear, thanks for the feedback. Do you want to create a PR for changing the docs?