Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure PR approvals #13

Closed
bocytko opened this issue Jan 9, 2025 · 3 comments
Closed

Configure PR approvals #13

bocytko opened this issue Jan 9, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@bocytko
Copy link
Member

bocytko commented Jan 9, 2025

There do not seem to be any approval requirements enforced in the repository.
@bocytko bocytko added the bug Something isn't working label Jan 9, 2025
@kostz
Copy link
Member

kostz commented Jan 9, 2025

@bocytko , yes, branch protection rules can't be enforced in provate repositories, so they will be immediately enforced once repository become public.
the same states for compr approvals,

@tkrop - please correct if I'm wrong

@bocytko
Copy link
Member Author

bocytko commented Jan 9, 2025

@kostz ok, let's keep the issue open to ensure we check this again after publishing

@bocytko
Copy link
Member Author

bocytko commented Jan 20, 2025

Successfully tested with #17

@bocytko bocytko closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bocytko @kostz