Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IngressClass introduced in Kubernetes v1.18 #357

Closed
mikkeloscar opened this issue Jul 8, 2020 · 3 comments
Closed

Add support for IngressClass introduced in Kubernetes v1.18 #357

mikkeloscar opened this issue Jul 8, 2020 · 3 comments
Labels
enhancement good first issue

Comments

@mikkeloscar
Copy link
Collaborator

Kubernetes v1.18 introduced a dedicated resource + field for defining IngressClass. See the documentation here: https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-class

It would make sense for the ingress-controller to support ingress class in this way going forward.

Related issue for skipper: zalando/skipper#1478
@mikkeloscar mikkeloscar mentioned this issue Jul 8, 2020
Merged
9 tasks
@universam1
Copy link
Contributor

Ran into this issue as well - apparently is not supported yet?

@mikkeloscar
Copy link
Collaborator Author

mikkeloscar commented Dec 2, 2020 •
edited
Loading

Yes, this is still not supported. For now you can use the annotation if you need this: kubernetes.io/ingress.class

@Xyaren Xyaren mentioned this issue Oct 19, 2021
Merged
szuecs pushed a commit that referenced this issue Oct 22, 2021
@Xyaren
#357 Implementation of IngressClassName (Kubernetes 1.18+) for filter…
bc76030 
…ing (#447)

* #357 Implementation of spec.ingressClassName as a filter for ingress matching

Signed-off-by: Tobias Günther <[email protected]>

* Fix test, adopt test data to only use ingressClassName, add yet-another test case, that uses spec AND annotation ingress class.

Signed-off-by: Tobias Günther <[email protected]>

* replace pointer to string with empty string handling for json struct

Signed-off-by: Tobias Günther <[email protected]>

* rename checkFilterSupport to supportedIngressClass

Signed-off-by: Tobias Günther <[email protected]>

* add test for v1 ingress

Signed-off-by: Tobias Günther <[email protected]>
@szuecs
Copy link
Member

szuecs commented Oct 22, 2021

Thanks to @Xyaren we have it now

@szuecs szuecs closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@szuecs @mikkeloscar @universam1